clk: Fix memory leak in devm_clk_notifier_register()
authorFei Shao <fshao@chromium.org>
Mon, 19 Jun 2023 03:22:53 +0000 (11:22 +0800)
committerStephen Boyd <sboyd@kernel.org>
Tue, 20 Jun 2023 19:03:21 +0000 (12:03 -0700)
commit7fb933e56f77a57ef7cfc59fc34cbbf1b1fa31ff
tree2794c4a6b511286e1b088c760fc094d945c261ca
parentbd73d1fd63d4f67dc78640c9ae4f83e20a021d76
clk: Fix memory leak in devm_clk_notifier_register()

devm_clk_notifier_register() allocates a devres resource for clk
notifier but didn't register that to the device, so the notifier didn't
get unregistered on device detach and the allocated resource was leaked.

Fix the issue by registering the resource through devres_add().

This issue was found with kmemleak on a Chromebook.

Fixes: 6d30d50d037d ("clk: add devm variant of clk_notifier_register")
Signed-off-by: Fei Shao <fshao@chromium.org>
Link: https://lore.kernel.org/r/20230619112253.v2.1.I13f060c10549ef181603e921291bdea95f83033c@changeid
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk.c