[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
authorVolodymyr Sapsai <vsapsai@apple.com>
Wed, 24 Oct 2018 22:40:54 +0000 (22:40 +0000)
committerVolodymyr Sapsai <vsapsai@apple.com>
Wed, 24 Oct 2018 22:40:54 +0000 (22:40 +0000)
commit7faf7ae0ad49672f5f9922bb1572595bfc8e7d1b
tree8fc01fab5b875394bc7d752ec4ad4caa78eaa2cf
parentee89b2e01dfb29ceb58748f9a8ad173430a01d18
[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.

'ignore-non-existent-contents' stopped working after r342232 in a way
that the actual attribute value isn't used and it works as if it is
always `true`.

Common use case for VFS iteration is iterating through files in umbrella
directories for modules. Ability to detect if some VFS entries point to
non-existing files is nice but non-critical. Instead of adding back
support for `'ignore-non-existent-contents': false` I am removing the
attribute, because such scenario isn't used widely enough and stricter
checks don't provide enough value to justify the maintenance.

Change is done both in LLVM and Clang, corresponding Clang commit is r345212.

rdar://problem/45176119

Reviewers: bruno

Reviewed By: bruno

Subscribers: hiraditya, dexonsmith, sammccall, cfe-commits

Differential Revision: https://reviews.llvm.org/D53228

llvm-svn: 345213
llvm/include/llvm/Support/VirtualFileSystem.h
llvm/lib/Support/VirtualFileSystem.cpp