pvr: Use the render passes' attachments array to setup ISP state
authorKarmjit Mahil <Karmjit.Mahil@imgtec.com>
Thu, 21 Sep 2023 14:16:09 +0000 (15:16 +0100)
committerMarge Bot <emma+marge@anholt.net>
Mon, 9 Oct 2023 16:43:46 +0000 (16:43 +0000)
commit7f510fe39f7773f9cd776bd5645638934e71248b
tree8dfc5146714b3fac5b7bc8c9d6429b97220c2f6c
parentc8556a8f2e2d2b2016b9e02eecac20102b51671c
pvr: Use the render passes' attachments array to setup ISP state

`pvr_setup_isp_faces_and_control()` can be called from a secondary
command buffer. The render pass info's `attachments` array is only
populated in the primary command buffer on which the render pass
was started, thus the `ds_aspect` being used always ended up being
`0` leading to incorrect ISP state being setup.

This commit changes the function to use the `attachments` array
from the render pass struct instead of the one from the recording
state.

dEQP tests fixed:
  dEQP-VK.renderpass.suballocation.attachment
    .{1.13, 1.65, 1.74, 3.219, 3.236, 3.314, 3.385, 4.426}

Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25351>
src/imagination/vulkan/pvr_cmd_buffer.c