csharp: Fix managed name when solving Get/SetType name clash
authorJoão Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Wed, 12 Feb 2020 15:39:51 +0000 (16:39 +0100)
committerJongmin Lee <jm105.lee@samsung.com>
Wed, 12 Feb 2020 21:14:37 +0000 (06:14 +0900)
commit7f3e0fe872e24b19b63969e3d5d1b441a2187f33
tree57cff020492793ffa50994a515f8587af10a372e
parente570fb100633b1a9e72ac70476b931026754920d
csharp: Fix managed name when solving Get/SetType name clash

Summary:
If you declare a property called "type", the generated getter method
would be called "GetType", clashing with "System.Object.GetType" method. The
current workaround for that is to straight-forwardly insert the respective
class/abstract's Eolian name into the function name (becoming, for example
"GetMy_ClassType"), sometimes getting inconsistent to not only other methods
but also with documentation (leading to XML errors, since a cref doc would
reference "GetMyClassType", which doesn't exists).

This patch fixes that by wrapping the Eolian name with the already existing
`managed_name` function.

Test Plan: Run ninja tests.

Reviewers: zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11331
src/bin/eolian_mono/eolian/mono/name_helpers.hh