locking/percpu-rwsem: Remove the embedded rwsem
authorPeter Zijlstra <peterz@infradead.org>
Wed, 30 Oct 2019 19:30:41 +0000 (20:30 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 11 Feb 2020 12:10:56 +0000 (13:10 +0100)
commit7f26482a872c36b2ee87ea95b9dcd96e3d5805df
tree0a0e843a50333cc34780860e3378ecae2c5a52bf
parent75ff64572e497578e238fefbdff221c96f29067a
locking/percpu-rwsem: Remove the embedded rwsem

The filesystem freezer uses percpu-rwsem in a way that is effectively
write_non_owner() and achieves this with a few horrible hacks that
rely on the rwsem (!percpu) implementation.

When PREEMPT_RT replaces the rwsem implementation with a PI aware
variant this comes apart.

Remove the embedded rwsem and implement it using a waitqueue and an
atomic_t.

 - make readers_block an atomic, and use it, with the waitqueue
   for a blocking test-and-set write-side.

 - have the read-side wait for the 'lock' state to clear.

Have the waiters use FIFO queueing and mark them (reader/writer) with
a new WQ_FLAG. Use a custom wake_function to wake either a single
writer or all readers until a writer.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Davidlohr Bueso <dbueso@suse.de>
Acked-by: Will Deacon <will@kernel.org>
Acked-by: Waiman Long <longman@redhat.com>
Tested-by: Juri Lelli <juri.lelli@redhat.com>
Link: https://lkml.kernel.org/r/20200204092403.GB14879@hirez.programming.kicks-ass.net
include/linux/percpu-rwsem.h
include/linux/wait.h
kernel/locking/percpu-rwsem.c
kernel/locking/rwsem.c
kernel/locking/rwsem.h