predict: Don't emit -Wsuggest-attribute=cold warning for functions which already...
authorJakub Jelinek <jakub@redhat.com>
Sun, 26 Mar 2023 18:15:05 +0000 (20:15 +0200)
committerJakub Jelinek <jakub@redhat.com>
Sun, 26 Mar 2023 18:15:05 +0000 (20:15 +0200)
commit7eca91d4781bb3df941f25c30b971dac66ba1b3d
treed8f648eb88d269d3b2d64b9c257992304121bcfc
parent9cdbe57362e5e1c3bfdec798dfd37de2b32b24bc
predict: Don't emit -Wsuggest-attribute=cold warning for functions which already have that attribute [PR105685]

In the following testcase, we predict baz to have cold
entry regardless of the user supplied attribute (as it call
unconditionally a cold function), but still issue
a -Wsuggest-attribute=cold warning despite it having that attribute
already.

The following patch avoids that.

2023-03-26  Jakub Jelinek  <jakub@redhat.com>

PR ipa/105685
* predict.cc (compute_function_frequency): Don't call
warn_function_cold if function already has cold attribute.

* c-c++-common/cold-2.c: New test.
gcc/predict.cc
gcc/testsuite/c-c++-common/cold-2.c [new file with mode: 0644]