i2c: mchp-pci1xxxx: Avoid cast to incompatible function type
authorSimon Horman <horms@kernel.org>
Wed, 10 May 2023 12:32:17 +0000 (14:32 +0200)
committerWolfram Sang <wsa@kernel.org>
Mon, 5 Jun 2023 08:43:45 +0000 (10:43 +0200)
commit7ebfd881abe9e0ea9557b29dab6aa28d294fabb4
treea9c4a675610af36b66e50209181c5774ee397cc6
parent8110bf24c82d08aa2ed1d09a2b996d06c41f2e67
i2c: mchp-pci1xxxx: Avoid cast to incompatible function type

Rather than casting pci1xxxx_i2c_shutdown to an incompatible function type,
update the type to match that expected by __devm_add_action.

Reported by clang-16 with W-1:

 .../i2c-mchp-pci1xxxx.c:1159:29: error: cast from 'void (*)(struct pci1xxxx_i2c *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
         ret = devm_add_action(dev, (void (*)(void *))pci1xxxx_i2c_shutdown, i2c);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ./include/linux/device.h:251:29: note: expanded from macro 'devm_add_action'
         __devm_add_action(release, action, data, #action)
                                   ^~~~~~

No functional change intended.
Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Reviewed-by: Tharun Kumar P<tharunkumar.pasumarthi@microchip.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-mchp-pci1xxxx.c