qdev: Do not let the user try to device_add when it cannot work
authorMarkus Armbruster <armbru@redhat.com>
Thu, 28 Nov 2013 16:27:03 +0000 (17:27 +0100)
committerAndreas Färber <afaerber@suse.de>
Sun, 22 Dec 2013 23:27:23 +0000 (00:27 +0100)
commit7ea5e78f3d8d64e99c4017ea211b7518f2629756
treea7fb7cd931cf6b48cee3de7e674244ca06827403
parentf3b176402fa92149320dcd5479916ccb39cfa0a8
qdev: Do not let the user try to device_add when it cannot work

Such devices have always been unavailable and omitted from the list of
available devices shown by device_add help.  Until commit 18b6dad
silently broke the former, setting up nasty traps for unwary users,
like this one:

    $ qemu-system-x86_64 -nodefaults -monitor stdio -display none
    QEMU 1.6.50 monitor - type 'help' for more information
    (qemu) device_add apic
    Segmentation fault (core dumped)

I call that a regression.  Fix it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
qdev-monitor.c