Repair support for launching ios/tv/watch simulator binaries through platform
authorAdrian Prantl <aprantl@apple.com>
Tue, 16 Jun 2020 23:25:09 +0000 (16:25 -0700)
committerAdrian Prantl <aprantl@apple.com>
Fri, 19 Jun 2020 16:42:44 +0000 (09:42 -0700)
commit7e825abd5704ce28b166f9463d4bd304348fd2a9
treeb4580228e2b80f4e28973d7ee413277a39740da4
parent6331c7d0bef8a0fccafe6333ba2004e50c752f19
Repair support for launching ios/tv/watch simulator binaries through platform

and delete a bunch (but not all) redundant code. If you compare the remaining implementations of Platform*Simulator.cpp, there is still an obvious leftover cleanup task.

Specifically, this patch

- removes SDK initialization from dotest (there is equivalent but more
  complete code in Makefile.rules)

- make Platform*Simulator inherit the generic implementation of
  PlatformAppleSimulator (more can be done here)

- simplify the platform logic in Makefile.rules

- replace the custom SDK finding logic in Platform*Simulator with XcodeSDK

- adds a test for each supported simulator

Differential Revision: https://reviews.llvm.org/D81980
24 files changed:
lldb/packages/Python/lldbsuite/test/dotest.py
lldb/packages/Python/lldbsuite/test/dotest_args.py
lldb/packages/Python/lldbsuite/test/make/Makefile.rules
lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm
lldb/test/API/functionalities/fat_archives/Makefile
lldb/test/API/lang/objcxx/class-name-clash/Makefile
lldb/test/API/macosx/find-app-in-bundle/Makefile
lldb/test/API/macosx/find-app-in-bundle/TestFindAppInBundle.py
lldb/test/API/macosx/find-dsym/bundle-with-dot-in-filename/Makefile
lldb/test/API/macosx/find-dsym/bundle-with-dot-in-filename/TestBundleWithDotInFilename.py
lldb/test/API/macosx/find-dsym/deep-bundle/Makefile
lldb/test/API/macosx/find-dsym/deep-bundle/TestDeepBundle.py
lldb/test/API/macosx/simulator/Makefile [new file with mode: 0644]
lldb/test/API/macosx/simulator/TestSimulatorPlatform.py [new file with mode: 0644]
lldb/test/API/macosx/simulator/hello.c [new file with mode: 0644]
lldb/test/API/macosx/universal/Makefile