mctp: fix use after free
authorTom Rix <trix@redhat.com>
Tue, 15 Feb 2022 02:05:41 +0000 (18:05 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Feb 2022 14:54:40 +0000 (14:54 +0000)
commit7e5b6a5c8c44310784c88c1c198dde79f6402f7b
tree89c5e52eda180af2545df6a5906da19831a26e59
parentef57640575406f57f5b3393cf57f457b0ace837e
mctp: fix use after free

Clang static analysis reports this problem
route.c:425:4: warning: Use of memory after it is freed
  trace_mctp_key_acquire(key);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
When mctp_key_add() fails, key is freed but then is later
used in trace_mctp_key_acquire().  Add an else statement
to use the key only when mctp_key_add() is successful.

Fixes: 4f9e1ba6de45 ("mctp: Add tracepoints for tag/key handling")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mctp/route.c