audio: Clean up inappropriate and unreachable use of hw_error()
authorMarkus Armbruster <armbru@redhat.com>
Thu, 17 Dec 2015 16:35:20 +0000 (17:35 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 13 Jan 2016 14:16:16 +0000 (15:16 +0100)
commit7e274652e4e2225298a2735c3dcc74f2f8ba7b07
tree4e40fcbf90fe3412d1de696ca6760ba7f6bff853
parent675463d9b6b2c2b65a713a6d906aeebe9e6750ae
audio: Clean up inappropriate and unreachable use of hw_error()

audio_init() should not use hw_error(), because dumping CPU registers
is unhelpful there, and aborting is wrong, because it can be called
called from an audio device's realize() method.

The two uses of hw_error() come from commit 0d9acba:

* When qemu_new_timer() fails.  It couldn't fail back then, and it
  can't fail now.  Drop the unreachable error handling.

* When no_audio_driver can't be initialized.  It couldn't fail back
  then, and it can't fail now.  Replace the error handling by an
  assertion.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
audio/audio.c