smb3: lower default deferred close timeout to address perf regression
authorSteve French <stfrench@microsoft.com>
Thu, 23 Mar 2023 20:10:26 +0000 (15:10 -0500)
committerSteve French <stfrench@microsoft.com>
Fri, 24 Mar 2023 19:37:12 +0000 (14:37 -0500)
commit7e0e76d99079be13c9961dde7c93b2d1ee665af4
treee60ab61c8221117f49797769da7e0c1a8ddd03bb
parentc24bb1a87dc3f2d77d410eaac2c6a295961bf50e
smb3: lower default deferred close timeout to address perf regression

Performance tests with large number of threads noted that the change
of the default closetimeo (deferred close timeout between when
close is done by application and when client has to send the close
to the server), to 5 seconds from 1 second, significantly degraded
perf in some cases like this (in the filebench example reported,
the stats show close requests on the wire taking twice as long,
and 50% regression in filebench perf). This is stil configurable
via mount parm closetimeo, but to be safe, decrease default back
to its previous value of 1 second.

Reported-by: Yin Fengwei <fengwei.yin@intel.com>
Reported-by: kernel test robot <yujie.liu@intel.com>
Link: https://lore.kernel.org/lkml/997614df-10d4-af53-9571-edec36b0e2f3@intel.com/
Fixes: 5efdd9122eff ("smb3: allow deferred close timeout to be configurable")
Cc: stable@vger.kernel.org # 6.0+
Tested-by: Yin Fengwei <fengwei.yin@intel.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/fs_context.h