vnc: Don't demote authentication scheme when changing password/disabling login
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 14 Feb 2012 12:37:29 +0000 (12:37 +0000)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 17 Feb 2012 15:58:21 +0000 (09:58 -0600)
commit7dfbfc7927c1f7ab9f6910768ed6d966645b5866
tree62fa7843679891c12ccbef59c19539c53be13838
parent4ed658ca925249021789d6a51fd6f99f68213f28
vnc: Don't demote authentication scheme when changing password/disabling login

Currently when disabling login in VNC, the password is cleared out and the
authentication protocol is forced to AUTH_VNC.  If you're using a stronger
authentication protocol, this has the effect of downgrading your security
protocol.

Fix this by only changing the authentication protocol if the current
authentication protocol is AUTH_NONE.  That ensures we're never downgrading.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
--
NB. This patch is derived from one posted by Anthony last year, which got
accidentally lost after Luiz took over the QMP series work

  https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg00392.html

 v1 -> v2
 - Make sure to not demote when changing password (Daniel)
 v2 -> v3
 - Rebase to latest GIT master wrt QMP changes
ui/vnc.c