v3dv: remove combined_idx support
authorAlejandro Piñeiro <apinheiro@igalia.com>
Tue, 10 Nov 2020 21:11:11 +0000 (22:11 +0100)
committerMarge Bot <eric+marge@anholt.net>
Sat, 14 Nov 2020 15:59:02 +0000 (15:59 +0000)
commit7da854e1864f61d821dc51ef0dba8b465d67ee4a
tree8c70aacf0c426aa765f5b811eebd2b215dac7363
parent429c33641275e02b17351ab24a693f2469cc36f3
v3dv: remove combined_idx support

Now that the v3d compiler has support for separated texture and
sampler indices, we can stop to combine them. Again, that's what
Vulkan allows after all.

As we are doing this we can't use anymore the texture format (coming
from the texture) to chose the return size (that is a sampling
parameter). We default for 32, and just go to 16 for shadow. We plan
to use SPIR-V RelaxedPrecision to use in more cases 16 bit. We would
do that on following patches.

v2 (from Iago feedback):
   * Fix typos/bad grammar on comments.
   * Move tex/sampler number assert to before the loop that fills
     tex/sampler info.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7545>
src/broadcom/vulkan/v3dv_pipeline.c
src/broadcom/vulkan/v3dv_private.h
src/broadcom/vulkan/v3dv_uniforms.c