net: remove duplicate fetch in sock_getsockopt
authorJingYi Hou <houjingyi647@gmail.com>
Mon, 17 Jun 2019 06:56:05 +0000 (14:56 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Jul 2019 11:14:47 +0000 (13:14 +0200)
commit7d76fc211609063cc22cb1cef2e3297630a31199
treef310f4d3f976f30de455a6deac2dfe0ba422d1f6
parent05dceb60e5dd7a40fd9b6c565a62ce272ed4e6a2
net: remove duplicate fetch in sock_getsockopt

[ Upstream commit d0bae4a0e3d8c5690a885204d7eb2341a5b4884d ]

In sock_getsockopt(), 'optlen' is fetched the first time from userspace.
'len < 0' is then checked. Then in condition 'SO_MEMINFO', 'optlen' is
fetched the second time from userspace.

If change it between two fetches may cause security problems or unexpected
behaivor, and there is no reason to fetch it a second time.

To fix this, we need to remove the second fetch.

Signed-off-by: JingYi Hou <houjingyi647@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/core/sock.c