CVE 2010-4352: Reject deeply nested variants
authorHavoc Pennington <hp@pobox.com>
Mon, 13 Dec 2010 02:08:43 +0000 (21:08 -0500)
committerWill Thompson <will.thompson@collabora.co.uk>
Mon, 20 Dec 2010 21:39:00 +0000 (21:39 +0000)
commit7d65a3a6ed8815e34a99c680ac3869fde49dbbd4
tree230fe4f9beaa1be2eb5137b3103fde668cf6f8df
parentf2905def7b65970724e57c2d57202de8d7138e98
CVE 2010-4352: Reject deeply nested variants

Add DBUS_INVALID_NESTED_TOO_DEEPLY validity problem and a test that
should generate it.

Previously, we rejected deep nesting in the signature, but
variants allow dynamic message nesting, conditional only
on the depth of the message body.

The nesting limit is 64, which was also the limit in static
signatures.  Empirically, dynamic nesting depth observed on my
Fedora 14 system doesn't exceed 2; 64 is really a huge limit.

https://bugs.freedesktop.org/show_bug.cgi?id=32321

Signed-Off-By: Colin Walters <walters@verbum.org>
Signed-off-by: Will Thompson <will.thompson@collabora.co.uk>
dbus/dbus-marshal-validate.c
dbus/dbus-marshal-validate.h
dbus/dbus-message-factory.c
doc/dbus-specification.xml