ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
authorNamjae Jeon <linkinjeon@kernel.org>
Wed, 20 Dec 2023 06:52:11 +0000 (15:52 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jan 2024 14:19:42 +0000 (15:19 +0100)
commit7d5f219f1ef69f27eb8cbfb794d634fc9c4d24ac
tree232ca8f6f60acd2ac5c20c32fbb1606e08600834
parent33fd5fb1258b32976f2d83f46a59832dde784831
ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()

commit d10c77873ba1e9e6b91905018e29e196fd5f863d upstream.

If ->NameOffset/Length is bigger than ->CreateContextsOffset/Length,
ksmbd_check_message doesn't validate request buffer it correctly.
So slab-out-of-bounds warning from calling smb_strndup_from_utf16()
in smb2_open() could happen. If ->NameLength is non-zero, Set the larger
of the two sums (Name and CreateContext size) as the offset and length of
the data area.

Reported-by: Yang Chaoming <lometsj@live.com>
Cc: stable@vger.kernel.org
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/smb/server/smb2misc.c