bpf, devmap: Use GFP_KERNEL for xdp bulk queue allocation
authorJun'ichi Nomura <junichi.nomura@nec.com>
Tue, 9 Feb 2021 08:24:52 +0000 (08:24 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 12 Feb 2021 23:11:26 +0000 (00:11 +0100)
commit7d4553b69fb335496c597c31590e982485ebe071
tree02eb509754ac0562d8b0c7d3746d1731cdf69241
parent17d8beda277a36203585943e70c7909b60775fd5
bpf, devmap: Use GFP_KERNEL for xdp bulk queue allocation

The devmap bulk queue is allocated with GFP_ATOMIC and the allocation
may fail if there is no available space in existing percpu pool.

Since commit 75ccae62cb8d42 ("xdp: Move devmap bulk queue into struct net_device")
moved the bulk queue allocation to NETDEV_REGISTER callback, whose context
is allowed to sleep, use GFP_KERNEL instead of GFP_ATOMIC to let percpu
allocator extend the pool when needed and avoid possible failure of netdev
registration.

As the required alignment is natural, we can simply use alloc_percpu().

Fixes: 75ccae62cb8d42 ("xdp: Move devmap bulk queue into struct net_device")
Signed-off-by: Jun'ichi Nomura <junichi.nomura@nec.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Toke Høiland-Jørgensen <toke@redhat.com>
Link: https://lore.kernel.org/bpf/20210209082451.GA44021@jeru.linux.bs1.fc.nec.co.jp
kernel/bpf/devmap.c