vulkanoverlaycompositor: don't do a potential use after free
authorMatthew Waters <matthew@centricular.com>
Fri, 10 Mar 2023 05:47:17 +0000 (16:47 +1100)
committerTim-Philipp Müller <tim@centricular.com>
Fri, 10 Mar 2023 13:02:44 +0000 (13:02 +0000)
commit7d2300efa1c57220ceb962f9385e1d66c6b1168c
tree26345ae3391d78c84cec087d684516358217ddde
parentd67aa49737414b957c4a6aa09e6aeb7f1fcc199d
vulkanoverlaycompositor: don't do a potential use after free

Removing a meta from a buffer means one doesn't have access to it
anymore.  Instead use the already reffed composition directly.

Fixes a use-after-free in the following pipeline:

... ! vulkanupload ! timeoverlay ! vulkanoverlaycompositor ! ...

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4147>
subprojects/gst-plugins-bad/ext/vulkan/vkoverlaycompositor.c