serdev: Fix serdev_uevent failure on ACPI enumerated serdev-controllers
authorHans de Goede <hdegoede@redhat.com>
Mon, 25 Dec 2017 20:50:45 +0000 (21:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Jan 2018 15:49:27 +0000 (16:49 +0100)
commit7d09995dcb0577b4a56aad7f2bb56f28604e8f1a
tree4926d58273be7e7aa93a4008dc5f3c0125613ceb
parentea507ce3e05a462e170db4b6af1002fb0ed72916
serdev: Fix serdev_uevent failure on ACPI enumerated serdev-controllers

ACPI enumerated serdev-controllers do not have an ACPI companion, the ACPI
companion belongs to the serdev-device child of the serdev-controller, not
to the controller itself. This was causing serdev_uevent to always return
-ENODEV when called on a serdev-controller leading to errors like these:

kernel: serial serial0: uevent: failed to send synthetic uevent

being logged. This commit modifies serdev_uevent to directly return 0
when called on an ACPI enumerated serdev-controller fixing this.

Note: I do not think that setting a modalias on a devicetree enumerated
serdev-controller makes sense either. So perhaps the !dev->of_node part of
the check can be dropped too, but I'm not entirely sure that doing this
on devicetree too is correct.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serdev/core.c