Revert "ubifs: dirty_cow_znode: Fix memleak in error handling path"
authorZhihao Cheng <chengzhihao1@huawei.com>
Wed, 1 Mar 2023 12:29:18 +0000 (20:29 +0800)
committerRichard Weinberger <richard@nod.at>
Sun, 23 Apr 2023 21:36:19 +0000 (23:36 +0200)
commit7d01cb27f6aebc54efbe28d8961a973b8f795b13
tree5c8c077e9ea85e77dfbb09fae7ab37f26b3f622b
parent3a36d20e012903f45714df2731261fdefac900cb
Revert "ubifs: dirty_cow_znode: Fix memleak in error handling path"

This reverts commit 122deabfe1428 (ubifs: dirty_cow_znode: Fix memleak
in error handling path).
After commit 122deabfe1428 applied, if insert_old_idx() failed, old
index neither exists in TNC nor in old-index tree. Which means that
old index node could be overwritten in layout_leb_in_gaps(), then
ubifs image will be corrupted in power-cut.

Fixes: 122deabfe1428 (ubifs: dirty_cow_znode: Fix memleak ... path)
Cc: stable@vger.kernel.org
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/tnc.c