Avoid using QSKIP in lieu of compile-time checks
authorJason McDonald <jason.mcdonald@nokia.com>
Tue, 4 Oct 2011 01:51:31 +0000 (11:51 +1000)
committerQt by Nokia <qt-info@nokia.com>
Wed, 5 Oct 2011 01:04:31 +0000 (03:04 +0200)
commit7cfad460c56319ba89c4a3a0bbcb2e54ab1cdbc6
tree5df8fca668dace17eea7b6c5ed82db8e87180105
parentc46f59fadf63b661d8611e5896f09fb85c17a00c
Avoid using QSKIP in lieu of compile-time checks

QSKIP is intended to be used to skip test functions that are found at
run-time to be inapplicable or unsafe.  If a test function can be
determined to be inapplicable at compile-time, the entire test function
should be omitted instead of replacing the body of the test function
with a QSKIP, which only serves to slow down test runs and to inflate
test run-rates with empty, inapplicable tests.

Task-number: QTQAINFRA-278

Change-Id: Ib2025339422749cf216e87ac414a3056250bf8f9
Reviewed-on: http://codereview.qt-project.org/5942
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
29 files changed:
tests/auto/corelib/codecs/qtextcodec/tst_qtextcodec.cpp
tests/auto/corelib/concurrent/qtconcurrentfilter/tst_qtconcurrentfilter.cpp
tests/auto/corelib/concurrent/qtconcurrentiteratekernel/tst_qtconcurrentiteratekernel.cpp
tests/auto/corelib/concurrent/qtconcurrentmap/tst_qtconcurrentmap.cpp
tests/auto/corelib/concurrent/qtconcurrentrun/tst_qtconcurrentrun.cpp
tests/auto/corelib/concurrent/qthreadpool/tst_qthreadpool.cpp
tests/auto/corelib/io/qdatastream/tst_qdatastream.cpp
tests/auto/corelib/io/qdir/tst_qdir.cpp
tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp
tests/auto/corelib/io/qfile/largefile/tst_largefile.cpp
tests/auto/corelib/io/qfile/tst_qfile.cpp
tests/auto/corelib/io/qfileinfo/tst_qfileinfo.cpp
tests/auto/corelib/io/qiodevice/tst_qiodevice.cpp
tests/auto/corelib/io/qprocess/tst_qprocess.cpp
tests/auto/corelib/io/qprocessenvironment/tst_qprocessenvironment.cpp
tests/auto/corelib/io/qsettings/tst_qsettings.cpp
tests/auto/corelib/io/qtextstream/tst_qtextstream.cpp
tests/auto/corelib/kernel/qeventloop/tst_qeventloop.cpp
tests/auto/corelib/kernel/qobject/tst_qobject.cpp
tests/auto/corelib/kernel/qsocketnotifier/tst_qsocketnotifier.cpp
tests/auto/corelib/kernel/qtipc/qsharedmemory/tst_qsharedmemory.cpp
tests/auto/corelib/kernel/qtipc/qsystemsemaphore/tst_qsystemsemaphore.cpp
tests/auto/corelib/thread/qthreadonce/tst_qthreadonce.cpp
tests/auto/corelib/tools/qbytearray/tst_qbytearray.cpp
tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp
tests/auto/corelib/tools/qlocale/tst_qlocale.cpp
tests/auto/corelib/tools/qsharedpointer/tst_qsharedpointer.cpp
tests/auto/corelib/tools/qstring/tst_qstring.cpp
tests/auto/corelib/tools/qstringlist/tst_qstringlist.cpp