scsi_tcp: block BH in TCP callbacks
authorEric Dumazet <edumazet@google.com>
Wed, 18 May 2016 00:44:06 +0000 (17:44 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 May 2016 18:36:49 +0000 (11:36 -0700)
commit7cb001d4c4fa7e1cc1a55388a9544e160dddc610
tree4a2f977161dfee41fb332eafac0bc420aba7c69a
parente00be9e4d0ffcc0121606229f0aa4b246d6881d7
scsi_tcp: block BH in TCP callbacks

iscsi_sw_tcp_data_ready() and iscsi_sw_tcp_state_change() were
using read_lock(&sk->sk_callback_lock) which is fine if caller
disabled BH.

TCP stack no longer has this requirement and can run from
process context.

Use read_lock_bh() variant to restore previous assumption.

Ideally this code could use RCU instead...

Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog")
Fixes: d41a69f1d390 ("tcp: make tcp_sendmsg() aware of socket backlog")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>
Cc: Venkatesh Srinivas <venkateshs@google.com>
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/scsi/iscsi_tcp.c