projects / platform / upstream / nodejs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 610727d) | patch
test: refactor test-fs-empty-readStream
authorRich Trott <rtrott@gmail.com>
Wed, 30 Dec 2015 22:02:28 +0000 (14:02 -0800)
committerMyles Borins <mborins@us.ibm.com>
Tue, 19 Jan 2016 19:52:35 +0000 (11:52 -0800)
commit7ca3c6c388fb342c499846c9d5a1f8af1c7244d3
tree4a95d29ec7b51789ca76df22148a806252870cectree | snapshot
parent610727dea7cfd491e6dad59ef4642641fd471942commit | diff
test: refactor test-fs-empty-readStream

Refactor test to remove unnecessary booleans and one unnecesary timer.
Instead, throw Error objects where appropriate and rely on
common.mustCall().

The timer seemed to be the source of an issue when parallelizing tests.

Ref: https://github.com/nodejs/node/pull/4476#issuecomment-168080875
PR-URL: https://github.com/nodejs/node/pull/4490
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
test/parallel/test-fs-empty-readStream.js diff | blob | history
Domain: Web Framework / Common;