ipmi: kcs_bmc: handle devm_kasprintf() failure case
authorNicholas Mc Guire <hofrat@osadl.org>
Wed, 21 Nov 2018 15:08:25 +0000 (16:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:50:21 +0000 (14:50 +0100)
commit7bfcb0230e4a99aecdec1482edd88dec49f1c7ef
treea22f86bbc9e7668bb55b296c064e187f44acf4ff
parenta1358d487d40c7434c607a7157218f9001285639
ipmi: kcs_bmc: handle devm_kasprintf() failure case

[ Upstream commit 42c7c6ef1e6fa5fc0425120f06f045190b1dda2d ]

devm_kasprintf() may return NULL if internal allocation failed so this
assignment is not safe. Moved the error exit path and added the !NULL
which then allows the devres manager to take care of cleanup.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: cd2315d471f4 ("ipmi: kcs_bmc: don't change device name")
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/ipmi/kcs_bmc.c