mtd: rawnand: meson: Don't skip cleanup after mtd_device_unregister() failed
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 3 Jun 2022 21:07:55 +0000 (23:07 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 9 Jun 2022 13:06:24 +0000 (15:06 +0200)
commit7beae6946255711d7914abe7c4914ff2691c4b8e
treed8d693de6727209ecc836875b25ae69fa2cbb7c4
parent413948cc6208c7b47dd9fc8c56cbb04c3b2381b3
mtd: rawnand: meson: Don't skip cleanup after mtd_device_unregister() failed

If mtd_device_unregister() fails (which it doesn't when used correctly),
the resources bound by the nand chip should be freed anyhow as returning
an error value doesn't prevent the device getting unbound.

Instead use WARN_ON on the return value similar to how other drivers do
it. Then meson_nfc_nand_chip_cleanup() returns 0 unconditionally and can
be changed to return void which allows further simplification in the
remove callback.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220603210758.148493-12-u.kleine-koenig@pengutronix.de
drivers/mtd/nand/raw/meson_nand.c