Minor refactor pkg_upgrade tool 94/260694/2
authorJunghyun Yeon <jungh.yeon@samsung.com>
Thu, 1 Jul 2021 07:24:29 +0000 (16:24 +0900)
committerJunghyun Yeon <jungh.yeon@samsung.com>
Fri, 2 Jul 2021 02:46:48 +0000 (11:46 +0900)
commit7be72dc5a00700ce5ecbe0cfd6ceefd7775516db
treec50c806ef5afc0a437a5a7ec5b6c24c3cb5ba30b
parent7b6b9e986fff5e7712dcdc70735c8b7b0e23e6ea
Minor refactor pkg_upgrade tool

- Refactor CompareVersion() to return verson compare result directly.
- Change enum type name to use more common abbreviation of "compare".
- Fix using UnzipPkgFromZip() to deliver std::string.
- Remove unnecessary variable initialization.
- Change return type of UnzipPkgFromZip to boolean.
- Replace some command and its arguments into constexpr.
- Extract BackendInvoker constructor with several functions for readability.
- Adjust ordering of include files with alphabetical order.

Change-Id: I4c6f7a8617da1e3fbbf6eca53fe308a8f0b61d8d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
13 files changed:
src/pkg_upgrade/include/backend_invoker.hh
src/pkg_upgrade/include/common_type.hh
src/pkg_upgrade/include/pkg_upgrader.hh
src/pkg_upgrade/include/rw_upgrader.hh
src/pkg_upgrade/src/backend_invoker.cc
src/pkg_upgrade/src/file_logbackend.cc
src/pkg_upgrade/src/pkg_finder.cc
src/pkg_upgrade/src/pkg_upgrader.cc
src/pkg_upgrade/src/pkg_upgrader_factory.cc
src/pkg_upgrade/src/ro_upgrader.cc
src/pkg_upgrade/src/rw2ro_upgrader.cc
src/pkg_upgrade/src/rw_upgrader.cc
src/pkg_upgrade/src/upgrader.cc