cert_stuff: avoid double free in the PKCS12 code
authorDaniel Stenberg <daniel@haxx.se>
Mon, 10 Jun 2013 21:42:48 +0000 (23:42 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Mon, 10 Jun 2013 21:42:48 +0000 (23:42 +0200)
commit7b97f03f09537fb488cbeda28767aa478618745c
treef4f95c13bd387d9f23949afaa9ab33ebc5f7b7c8
parentce362e8eb9c6fe8600058c7b88f40a83b0af1794
cert_stuff: avoid double free in the PKCS12 code

In the pkcs12 code, we get a list of x509 records returned from
PKCS12_parse but when iterating over the list and passing each to
SSL_CTX_add_extra_chain_cert() we didn't also properly remove them from
the "stack", which made them get freed twice (both in sk_X509_pop_free()
and then later in SSL_CTX_free).

This isn't really documented anywhere...

Bug: http://curl.haxx.se/bug/view.cgi?id=1236
Reported-by: Nikaiw
lib/ssluse.c