io_uring: gate iowait schedule on having pending requests
authorJens Axboe <axboe@kernel.dk>
Mon, 24 Jul 2023 17:28:17 +0000 (11:28 -0600)
committerJens Axboe <axboe@kernel.dk>
Mon, 24 Jul 2023 17:44:35 +0000 (11:44 -0600)
commit7b72d661f1f2f950ab8c12de7e2bc48bdac8ed69
tree7e1831c46bf4f4065dba29f192440b2a89586c11
parent07e981137f17e5275b6fa5fd0c28b0ddb4519702
io_uring: gate iowait schedule on having pending requests

A previous commit made all cqring waits marked as iowait, as a way to
improve performance for short schedules with pending IO. However, for
use cases that have a special reaper thread that does nothing but
wait on events on the ring, this causes a cosmetic issue where we
know have one core marked as being "busy" with 100% iowait.

While this isn't a grave issue, it is confusing to users. Rather than
always mark us as being in iowait, gate setting of current->in_iowait
to 1 by whether or not the waiting task has pending requests.

Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/io-uring/CAMEGJJ2RxopfNQ7GNLhr7X9=bHXKo+G5OOe0LUq=+UgLXsv1Xg@mail.gmail.com/
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217699
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217700
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reported-by: Phil Elwell <phil@raspberrypi.com>
Tested-by: Andres Freund <andres@anarazel.de>
Fixes: 8a796565cec3 ("io_uring: Use io_schedule* in cqring wait")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/io_uring.c