drm/vc4: Correct logic on stopping an HVS channel
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Thu, 26 Oct 2023 16:46:13 +0000 (17:46 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:35:11 +0000 (11:35 +0000)
commit7b3a9c498461630b569a9ebdbeb27b3864a9de30
treebb36312d406b34593ca725f02ab121ace8340743
parent727fd79cf93977aafced6bac5e16d951eea51e33
drm/vc4: Correct logic on stopping an HVS channel

When factoring out __vc4_hvs_stop_channel, the logic got inverted from
if (condition)
  // stop channel
to
if (condition)
  goto out
//stop channel
out:
and also changed the exact register writes used to stop the channel.

Correct the logic so that the channel is actually stopped, and revert
to the original register writes.

Fixes: 6d01a106b4c8 ("drm/vc4: crtc: Move HVS init and close to a function")
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/gpu/drm/vc4/vc4_hvs.c