crypto: cavium/nitrox - remove check of list iterator against head past the loop...
authorJakob Koschel <jakobkoschel@gmail.com>
Thu, 31 Mar 2022 21:59:10 +0000 (23:59 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 8 Apr 2022 08:26:43 +0000 (16:26 +0800)
commit7b2206d8809259b0dd297f0ccf017bf2dea98a02
tree54af3d881baa8b1937975775d5a764128e022c52
parent4e2c87949f2b9909d3daa8d9cd4b6d5077b6e0c2
crypto: cavium/nitrox - remove check of list iterator against head past the loop body

When list_for_each_entry() completes the iteration over the whole list
without breaking the loop, the iterator value will be a bogus pointer
computed based on the head element.

While it is safe to use the pointer to determine if it was computed
based on the head element, either with list_entry_is_head() or
&pos->member == head, using the iterator variable after the loop should
be avoided.

In preparation to limit the scope of a list iterator to the list
traversal loop, use a dedicated pointer to point to the found element [1].

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/cavium/nitrox/nitrox_main.c