Resolve fallback type before trying to make constructed generic type (#6511)
authorTim Barham <tim.barham@microsoft.com>
Thu, 13 Jun 2019 18:21:55 +0000 (04:21 +1000)
committerStephane Delcroix <stephane@delcroix.org>
Thu, 13 Jun 2019 18:21:55 +0000 (20:21 +0200)
commit7b21069fad266d498c9494d94af0c86c2f832bae
tree32a82338a9e11775fbd2008a83072ada484ccde5
parent216e565b0762577ee581c616c872abdba21ba05c
Resolve fallback type before trying to make constructed generic type (#6511)

* Resolve fallback type before trying to make constructed generic type

The FallbackTypeResolver hander in the Forms previewer does not have access to the x:TypeArguments attribute, so if it constructs a proxy generic type from metadata it can't construct it. So the previewer has to create an unconstructed generic type, and Forms will need to construct it.

So we need to move the code that constructs the generic type after the call to FallbackTypeResolver.

(cherry picked from commit 5acfea4f457453856a8905002f4d35c8e9aad106)

* Fix error building DesignTimeLoaderTests in 4.1
Xamarin.Forms.Xaml.UnitTests/DesignTimeLoaderTests.cs
Xamarin.Forms.Xaml/XamlParser.cs