Delete COMPlus_FinalizeOnShutdown (dotnet/coreclr#23595)
authorJan Kotas <jkotas@microsoft.com>
Sat, 13 Apr 2019 15:09:31 +0000 (08:09 -0700)
committerGitHub <noreply@github.com>
Sat, 13 Apr 2019 15:09:31 +0000 (08:09 -0700)
commit7ae2eb893aebf8caea5c46e7b3e14a86d8172b98
tree27809f02e1fe7d68878b7c39fdf0ffd678ef8f43
parentd146f4c9a67ce1c6164e5bac26d705873343598e
Delete COMPlus_FinalizeOnShutdown (dotnet/coreclr#23595)

This compat quirk is increasingly more broken since the framework is generally not compatible with, and we have not heard anybody actually using it.

Changed Environment.HasShutdownStarted to unconditionally return false. It does not make sense for it to ever return true with shutdown finalization disabled.

Commit migrated from https://github.com/dotnet/coreclr/commit/8913aaa1388e263d537b19e78caaed6b124fc0ea
27 files changed:
src/coreclr/src/System.Private.CoreLib/src/System/Environment.CoreCLR.cs
src/coreclr/src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
src/coreclr/src/System.Private.CoreLib/src/System/Reflection/LoaderAllocator.cs
src/coreclr/src/System.Private.CoreLib/src/System/Threading/ClrThreadPoolPreAllocatedOverlapped.cs
src/coreclr/src/classlibnative/bcltype/system.cpp
src/coreclr/src/classlibnative/bcltype/system.h
src/coreclr/src/inc/MSCOREE.IDL
src/coreclr/src/inc/clrconfigvalues.h
src/coreclr/src/pal/prebuilt/inc/mscoree.h
src/coreclr/src/utilcode/posterror.cpp
src/coreclr/src/vm/appdomain.cpp
src/coreclr/src/vm/ceemain.cpp
src/coreclr/src/vm/ecalllist.h
src/coreclr/src/vm/eepolicy.cpp
src/coreclr/src/vm/excep.cpp
src/coreclr/src/vm/finalizerthread.cpp
src/coreclr/src/vm/finalizerthread.h
src/coreclr/src/vm/frames.cpp
src/coreclr/src/vm/frames.h
src/coreclr/src/vm/threads.cpp
src/coreclr/src/vm/threadsuspend.cpp
src/coreclr/src/vm/vars.hpp
src/coreclr/src/vm/win32threadpool.cpp
src/libraries/System.Private.CoreLib/src/System/Gen2GcCallback.cs
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/ConditionalWeakTable.cs
src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.cs
src/libraries/System.Private.CoreLib/src/System/Threading/Timer.cs