netfilter: xt_physdev: Fix spurious error message in physdev_mt_check
authorTodd Seidelmann <tseidelmann@linode.com>
Wed, 21 Aug 2019 15:47:53 +0000 (11:47 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Sep 2019 05:17:01 +0000 (07:17 +0200)
commit7ac5947f7578d84036bdb5b5acd25228c8ab669f
tree32ea4de909c9fbf58ae68797c32c3ebf78b2ef98
parente997c0730520c8e84291ed049ce4afe2d5a4ec5b
netfilter: xt_physdev: Fix spurious error message in physdev_mt_check

[ Upstream commit 3cf2f450fff304be9cf4868bf0df17f253bc5b1c ]

Simplify the check in physdev_mt_check() to emit an error message
only when passed an invalid chain (ie, NF_INET_LOCAL_OUT).
This avoids cluttering up the log with errors against valid rules.

For large/heavily modified rulesets, current behavior can quickly
overwhelm the ring buffer, because this function gets called on
every change, regardless of the rule that was changed.

Signed-off-by: Todd Seidelmann <tseidelmann@linode.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/xt_physdev.c