cxl: avoid returning uninitialized error code
authorArnd Bergmann <arnd@arndb.de>
Mon, 13 Feb 2023 10:12:11 +0000 (11:12 +0100)
committerDan Williams <dan.j.williams@intel.com>
Tue, 14 Feb 2023 16:36:34 +0000 (08:36 -0800)
commit7abcb0b10668eaf3c174ff383f3b2a7a8c95fb34
tree317ee61cbfd6525da6f19b0bcf552bee84449d2c
parent09d09e04d2fcf88c4620dd28097e0e2a8f720eac
cxl: avoid returning uninitialized error code

The new cxl_add_to_region() function returns an uninitialized
value on success:

drivers/cxl/core/region.c:2628:6: error: variable 'rc' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
        if (IS_ERR(cxlr)) {
            ^~~~~~~~~~~~
drivers/cxl/core/region.c:2654:9: note: uninitialized use occurs here
        return rc;

Simplify the logic to have the rc variable always initialized in the
same place.

Fixes: a32320b71f08 ("cxl/region: Add region autodiscovery")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230213101220.3821689-1-arnd@kernel.org
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/core/region.c