udp_tunnel: Add checks for nla_nest_start() in __udp_tunnel_nic_dump_write()
authorYuan Can <yuancan@huawei.com>
Tue, 29 Nov 2022 01:39:34 +0000 (01:39 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 29 Nov 2022 16:44:24 +0000 (08:44 -0800)
commit7a945ce0c19bbdf821d5f7ce1515e7fb8e444465
treec73ac81f7f64668556960d25b6e4d2ea880d942a
parenta61474c41e8c530c54a26db4f5434f050ef7718d
udp_tunnel: Add checks for nla_nest_start() in __udp_tunnel_nic_dump_write()

As the nla_nest_start() may fail with NULL returned, the return value
should be checked.

Note that this is not a real bug, nothing will break here.
The next nla_put() will fail as well and we'll bail (and
nla_nest_cancel() can handle NULL). But we keep getting
those "fixes" so whatever.

Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20221129013934.55184-1-yuancan@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/udp_tunnel_nic.c