drm/i915/gem: Serialise object before changing cache-level
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 13 Dec 2019 22:31:40 +0000 (22:31 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Sat, 14 Dec 2019 11:03:49 +0000 (11:03 +0000)
commit7a90f89904afe66ff029bd784679aa293baacb72
tree24c86c90a419ec9683050f9d581f2043466943b1
parent9c569784a422e9eaa1c6f61e46a41011391e4d1d
drm/i915/gem: Serialise object before changing cache-level

Wait for the object to be idle before changing its cache-level and
unbinding. This was dropped as supposedly superfluous from commit
8b1c78e06e61 ("drm/i915: Avoid calling i915_gem_object_unbind holding
object lock"), but it turns out to prevent some cache dirt escaping.
Smells like papering over a race...

Closes: https://gitlab.freedesktop.org/drm/intel/issues/820
Fixes: 8b1c78e06e61 ("drm/i915: Avoid calling i915_gem_object_unbind holding object lock")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
Acked-by: Andi Shyti <andi.shyti@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191213223140.1830738-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gem/i915_gem_domain.c