Revert "Add SkImageInfoValidConversion() and SkImageInfoIsValid"
authorBrian Osman <brianosman@google.com>
Sat, 14 Jan 2017 23:43:24 +0000 (23:43 +0000)
committerSkia Commit-Bot <skia-commit-bot@chromium.org>
Sun, 15 Jan 2017 00:15:34 +0000 (00:15 +0000)
commit7a6c9f7be115031a8a86fdae20e8869fd973fdb6
treecfea263ca408161e7b57aee4dd31c26372fbc985
parent8bbdd49805bd77fec61e6e31f59d31a361e8be30
Revert "Add SkImageInfoValidConversion() and SkImageInfoIsValid"

This reverts commit cf5d6caff7a58f1c7ecc36d9a91ccdada5fc7b78.

Reason for revert: Chrome DEPS roll failing, based on the unit tests, I suspect this is the cause.

Original change's description:
> Add SkImageInfoValidConversion() and SkImageInfoIsValid
>
> The idea is share these standards for the following:
> SkImage::readPixels()
> SkCanvas::readPixels()
> SkCanvas::writePixels()
> SkBitmap::readPixels()
> SkPixmap::readPixels()
>
> On the raster side, SkPixmap::readPixels() is the right
> place to check, because all raster calls go through
> there eventually.  Then at lower levels (ex: SkPixelInfo),
> we can assert.
>
> There's not really a unifying location for gpu calls,
> so I've added this in multiple places.  I haven't really
> dug into the gpu code to SkASSERT() on invalid cases
> that we will have already caught.
>
> Follow-up work:
> Similar refactor for SkReadPixelRec::trim().
> Code cleanup in SkPixelInfo::CopyPixels()
>
> BUG=skia:6021
>
> Change-Id: I91ecce10e46c1a6530f0af24a9eb8226dbecaaa2
> Reviewed-on: https://skia-review.googlesource.com/6887
> Reviewed-by: Brian Osman <brianosman@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
>

TBR=mtklein@google.com,msarett@google.com,brianosman@google.com,reed@google.com,reviews@skia.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=skia:6021

Change-Id: I63b88e90bdbb3051a14de00ac73a8351ab776d25
Reviewed-on: https://skia-review.googlesource.com/7095
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
gm/showmiplevels.cpp
src/core/SkBitmap.cpp
src/core/SkConfig8888.cpp
src/core/SkImageInfo.cpp
src/core/SkImageInfoPriv.h [deleted file]
src/core/SkPixmap.cpp
src/gpu/SkGpuDevice.cpp
src/image/SkImage_Gpu.cpp
tests/SpecialImageTest.cpp