drm: Remove SCATTERLIST_MAX_SEGMENT
authorJason Gunthorpe <jgg@nvidia.com>
Wed, 28 Oct 2020 19:15:26 +0000 (16:15 -0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 2 Nov 2020 13:42:57 +0000 (14:42 +0100)
commit7a60c2dd0f575ab14a457e99582af0ca1e072a74
treee243aaf15c18c1a8e45528884ffcc7caf398f6f1
parent95d7a1a6f867f5e6acf62e07a463e0bea1d47b68
drm: Remove SCATTERLIST_MAX_SEGMENT

Since commit 9a40401cfa13 ("lib/scatterlist: Do not limit max_segment to
PAGE_ALIGNED values") the max_segment input to sg_alloc_table_from_pages()
does not have to be any special value. The new algorithm will always
create something less than what the user provides. Thus eliminate this
confusing constant.

- vmwgfx should use the HW capability, not mix in the OS page size for
  calling dma_set_max_seg_size()

- i915 uses i915_sg_segment_size() both for sg_alloc_table_from_pages
  and for some open coded sgl construction. This doesn't change the value
  since rounddown(size, UINT_MAX) == SCATTERLIST_MAX_SEGMENT

- drm_prime_pages_to_sg uses it as a default if max_segment is zero,
  UINT_MAX is fine to use directly.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Thomas Hellstrom <thellstrom@vmware.com>
Cc: Qian Cai <cai@lca.pw>
Cc: "Ursulin, Tvrtko" <tvrtko.ursulin@intel.com>
Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/0-v1-44733fccd781+13d-rm_scatterlist_max_jgg@nvidia.com
drivers/gpu/drm/drm_prime.c
drivers/gpu/drm/i915/i915_scatterlist.h
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
include/linux/scatterlist.h
tools/testing/scatterlist/main.c