[lldb] Remove redundant calls to set eReturnStatusFailed
authorDavid Spickett <david.spickett@linaro.org>
Wed, 16 Jun 2021 12:56:51 +0000 (13:56 +0100)
committerDavid Spickett <david.spickett@linaro.org>
Thu, 17 Jun 2021 11:21:54 +0000 (12:21 +0100)
commit7a580f3c28cf47a7e489faa1fc1ab7b88d9a5dbd
treed6e721672678b12262a43c60570949b2c15786b0
parent983ed1b58ef9d0f97c9cec2876f631e47609d437
[lldb] Remove redundant calls to set eReturnStatusFailed

Since https://reviews.llvm.org/D103701 AppendError<...>
sets this for you.

This change includes all of the non-command uses.

Some uses remain where it's either tricky to reason about
the logic, or they aren't paired with AppendError calls.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D104379
lldb/source/API/SBCommandInterpreter.cpp
lldb/source/Breakpoint/BreakpointIDList.cpp
lldb/source/Interpreter/CommandAlias.cpp
lldb/source/Interpreter/CommandInterpreter.cpp
lldb/source/Interpreter/Options.cpp
lldb/source/Interpreter/ScriptInterpreter.cpp
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp