regulator: as3711: Fix the logic in as3711_sel_check
authorAxel Lin <axel.lin@ingics.com>
Fri, 23 Nov 2012 16:53:22 +0000 (00:53 +0800)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Tue, 27 Nov 2012 20:25:18 +0000 (20:25 +0000)
commit7a4beda0c6a87af26b7e2144842a0205fa9fd674
tree2e237837116ca706e6ef114379c8cb483986e34a
parent16ed9f0701d2bb06d96754ba1d3edbf9aa5faeef
regulator: as3711: Fix the logic in as3711_sel_check

Below equation means the "voltage" is the "smallest" voltage within specific
range.

ret = DIV_ROUND_UP(min - bottom) / step;
voltage = ret * step + bottom;

If we do try 1 down when (voltage > max), new voltage is then less than min
voltage. Which means the new voltage is not in the requested voltage range.

This patch also includes below cleanups:
- Use DIV_ROUND_UP
- rename variable 'ret' to 'sel' for better readability because as3711_sel_check
  returns the selector.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/regulator/as3711-regulator.c