tpm: return -ENODEV if np is not set
authorColin Ian King <colin.king@canonical.com>
Tue, 15 Nov 2016 13:27:22 +0000 (13:27 +0000)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Sun, 27 Nov 2016 23:31:32 +0000 (01:31 +0200)
commit79eec5b940cffff14c7bd1b9eb856ccb36274cc2
treef8985c0022ce634eed180a5968a35f690ee7ba73
parent5efae7d6b07f37939f8f99d0983d5346f0c3e4e6
tpm: return -ENODEV if np is not set

device_node np contains a garbage value from the stack and it
is only set if chip->dev.parent->of_node is not null.  Thus the
check for a null np won't spot a garbage value of np from the
stack if chip->dev.parent->of_node is null and if np contains
an garbage non-null value.

I believe the correct fix is to return -ENODEV if and only if
chip->dev.parent->of_node is null.

Found with static analysis by CoverityScan, CID 1377755

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_of.c