i2c: Restore initial power state if probe fails
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 14 Nov 2022 12:20:34 +0000 (13:20 +0100)
committerWolfram Sang <wsa@kernel.org>
Mon, 14 Nov 2022 19:46:31 +0000 (20:46 +0100)
commit79ece9b292af6b0edcfb4d67a00711d25507640b
tree4d0dcc707942df8af08e47ed761472370eb655dc
parent145900cf91c4b32ac05dbc8675a0c7f4a278749d
i2c: Restore initial power state if probe fails

A driver that supports I2C_DRV_ACPI_WAIVE_D0_PROBE is not expected to
power off a device that it has not powered on previously.

For devices operating in "full_power" mode, the first call to
`i2c_acpi_waive_d0_probe` will return 0, which means that the device
will be turned on with `dev_pm_domain_attach`.

If probe fails the second call to `i2c_acpi_waive_d0_probe` will
return 1, which means that the device will not be turned off.
This is, it will be left in a different power state. Lets fix it.

Reviewed-by: Hidenori Kobayashi <hidenorik@chromium.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: stable@vger.kernel.org
Fixes: b18c1ad685d9 ("i2c: Allow an ACPI driver to manage the device's power state during probe")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/i2c-core-base.c