blockjob: Fix hang in block_job_finish_sync
authorFam Zheng <famz@redhat.com>
Tue, 2 Feb 2016 02:12:24 +0000 (10:12 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 9 Feb 2016 13:52:26 +0000 (13:52 +0000)
commit794f01414f9f4c4d0c6f1961154674961941c197
treea2fb49a44557ac1899e2c37c591a4a5e763edea4
parentad523bca56a7202d2498c550a41be5c986c4d33c
blockjob: Fix hang in block_job_finish_sync

With a mirror job running on a virtio-blk dataplane disk, sending "q" to
HMP will cause a dead loop in block_job_finish_sync.

This is because the aio_poll() only processes the AIO context of bs
which has no more work to do, while the main loop BH that is scheduled
for setting the job->completed flag is never processed.

Fix this by adding a flag in BlockJob structure, to track which context
to poll for the block job to make progress. Its value is set to true
when block_job_coroutine_complete() is called, and is checked in
block_job_finish_sync to determine which context to poll.

Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-id: 1454379144-29807-1-git-send-email-famz@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
blockjob.c
include/block/blockjob.h