drm/i915: Error checks in gen6_set_rps
authorBen Widawsky <ben@bwidawsk.net>
Sat, 8 Sep 2012 02:43:42 +0000 (19:43 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 20 Sep 2012 12:23:01 +0000 (14:23 +0200)
commit792496368bcd766926239a5ad105ca9aad797b34
tree0d50f6c63f4700507f5a58866cc053b1d7680ed7
parentd5570a72439b2d972c915208266440c2f330d03d
drm/i915: Error checks in gen6_set_rps

With the new "standardized" sysfs interfaces we need to be a bit more
careful about setting the RPS values.

Because the sysfs code and the rps workqueue can run at the same time,
if the sysfs setter wins the race to the mutex, the workqueue can come
in and set a value which is out of range (ie. we're no longer protecting
by RPINTLIM).

I was not able to actually make this error occur in testing.

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_irq.c
drivers/gpu/drm/i915/intel_pm.c