projects / platform / upstream / llvm.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 867e7d1) | patch
Calling SBDebugger::CeeateTarget being called on multiple threads was crashing LLDB.
authorGreg Clayton <gclayton@apple.com>
Fri, 9 Dec 2016 01:21:14 +0000 (01:21 +0000)
committerGreg Clayton <gclayton@apple.com>
Fri, 9 Dec 2016 01:21:14 +0000 (01:21 +0000)
commit7904046c33d8c8a24e1d78303bf0ebc61d7d9ef1
tree9369d32b2747e41bfe1e2d9843cb028d9068e043tree | snapshot
parent867e7d17655367377137393ea7d2fa68268d3001commit | diff
Calling SBDebugger::CeeateTarget being called on multiple threads was crashing LLDB.

I found the race condition in:

ScriptInterpreter *CommandInterpreter::GetScriptInterpreter(bool can_create);

More than one "ScriptInterpreter *" was being returned due to the race which caused any clients with the first one to now be pointing to freed memory and we would quickly crash.

Added a test to catch this so we don't regress.

<rdar://problem/28356584>

llvm-svn: 289169
lldb/include/lldb/Interpreter/CommandInterpreter.h diff | blob | history
lldb/packages/Python/lldbsuite/test/api/multiple-targets/Makefile [new file with mode: 0644] blob
lldb/packages/Python/lldbsuite/test/api/multiple-targets/TestMultipleTargets.py [new file with mode: 0644] blob
lldb/packages/Python/lldbsuite/test/api/multiple-targets/main.cpp [new file with mode: 0644] blob
lldb/source/Interpreter/CommandInterpreter.cpp diff | blob | history
Domain: System / Toolchain;