drm/bridge: fix stack usage warning on old gcc
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 Apr 2020 21:53:54 +0000 (23:53 +0200)
committerSam Ravnborg <sam@ravnborg.org>
Wed, 29 Apr 2020 20:35:50 +0000 (22:35 +0200)
commit78b0d99a68ecdc84728c99f4fef71942e9ecf35a
tree84f0e7fd32d21e2518467481afe2f98edd4cb2ad
parent6d4f3e2bfc4968eba13ea41bd3040ed76733324b
drm/bridge: fix stack usage warning on old gcc

Some older versions of gcc badly optimize code that passes
an inline function argument into another function by reference,
causing huge stack usage:

drivers/gpu/drm/bridge/tc358768.c: In function 'tc358768_bridge_pre_enable':
drivers/gpu/drm/bridge/tc358768.c:840:1: error: the frame size of 2256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]

Use a temporary variable as a workaround and add a comment pointing
to the gcc bug.

Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200428215408.4111675-1-arnd@arndb.de
drivers/gpu/drm/bridge/tc358768.c