platform/surface: aggregator: Enforce use of target-ID enum in device ID macros
authorMaximilian Luz <luzmaximilian@gmail.com>
Fri, 2 Dec 2022 22:33:26 +0000 (23:33 +0100)
committerHans de Goede <hdegoede@redhat.com>
Thu, 2 Feb 2023 21:48:20 +0000 (22:48 +0100)
commit78abf1b5205534bb7deda408aa5b9b7e0bf1982e
tree3a4a7491db9959e229d24179aadd5216bea415ac
parentea11bf4eb59e029cc54ad294126098dce67e321a
platform/surface: aggregator: Enforce use of target-ID enum in device ID macros

Similar to the target category (TC), the target ID (TID) can be one
value out of a small number of choices, given in enum ssam_ssh_tid.

In the device ID macros, SSAM_SDEV() and SSAM_VDEV() we already use text
expansion to, both, remove some textual clutter for the target category
values and enforce that the value belongs to the known set. Now that we
know the names for the target IDs, use the same trick for them as well.

Also rename the SSAM_ANY_x macros to SSAM_SSH_x_ANY to better fit in.

Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Link: https://lore.kernel.org/r/20221202223327.690880-9-luzmaximilian@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/hid/surface-hid/surface_hid.c
drivers/platform/surface/surface_aggregator_hub.c
drivers/platform/surface/surface_aggregator_tabletsw.c
drivers/platform/surface/surface_dtx.c
drivers/platform/surface/surface_platform_profile.c
drivers/power/supply/surface_battery.c
drivers/power/supply/surface_charger.c
include/linux/surface_aggregator/device.h