[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop...
authorOrlando Cazalet-Hyams <orlando.hyams@sony.com>
Tue, 7 May 2019 15:37:38 +0000 (15:37 +0000)
committerOrlando Cazalet-Hyams <orlando.hyams@sony.com>
Tue, 7 May 2019 15:37:38 +0000 (15:37 +0000)
commit78a6062c24dc51180101666b82afa8d7fab920d1
tree7b4b64e5b211da4c39fdd123e8fa6cbe0c3e5467
parenteeed7ee2cc7cbd49a906bed05a69140647ebb6d2
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion

Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=39024

The bug reports that a vectorized loop is stepped through 4 times and each step through the loop seemed to show a different path. I found two problems here:

A) An incorrect line number on a preheader block (for.body.preheader) instruction causes a step into the loop before it begins.
B) Instructions in the middle block have different line numbers which give the impression of another iteration.

In this patch I give all of the middle block instructions the line number of the scalar loop latch terminator branch. This seems to provide the smoothest debugging experience because the vectorized loops will always end on this line before dropping into the scalar loop. To solve problem A I have altered llvm::SplitBlockPredecessors to accommodate loop header blocks.

Reviewers: samsonov, vsk, aprantl, probinson, anemet, hfinkel

Reviewed By: hfinkel

Subscribers: bjope, jmellorcrummey, hfinkel, gbedwell, hiraditya, zzheng, llvm-commits

Tags: #llvm, #debug-info

Differential Revision: https://reviews.llvm.org/D60831

llvm-svn: 360162
llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
llvm/test/Transforms/LoopSimplify/dbg-loc.ll
llvm/test/Transforms/LoopSimplify/do-preheader-dbg.ll [new file with mode: 0755]
llvm/test/Transforms/LoopSimplify/for-preheader-dbg.ll [new file with mode: 0755]
llvm/test/Transforms/LoopUnroll/runtime-loop1.ll
llvm/test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll
llvm/test/Transforms/LoopVectorize/X86/vectorization-remarks-profitable.ll
llvm/test/Transforms/LoopVectorize/debugloc.ll
llvm/test/Transforms/LoopVectorize/fix-reduction-dbg.ll [new file with mode: 0755]
llvm/test/Transforms/LoopVectorize/unsafe-dep-remark.ll