ASoC: mediatek: mt8195: correct pcmif BE dai control flow
authorTrevor Wu <trevor.wu@mediatek.com>
Thu, 30 Dec 2021 08:47:30 +0000 (16:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:04:17 +0000 (11:04 +0100)
commit78926da03360c3dbba0ccad8f934a8f7f5a29cc7
treea19a95adce0e48f3e67dc48451f40054f5d3eeb0
parent1cf0a19e33ad7f3b435d99b52ab41ce4feb892a5
ASoC: mediatek: mt8195: correct pcmif BE dai control flow

[ Upstream commit 2355028c0c54c03afb66c589347f1dc9f6fe2e38 ]

Originally, the conditions for preventing reentry are not correct.
dai->component->active is not the state specifically for pcmif dai, so it
is not a correct condition to indicate the status of pcmif dai.
On the other hand, snd_soc_dai_stream_actvie() in prepare ops for both
playback and capture possibly return true at the first entry when these
two streams are opened at the same time.

In the patch, I refer to the implementation in mt8192-dai-pcm.c.
Clock and enabling bit for PCMIF are managed by DAPM, and the condition
for prepare ops is replaced by the status of dai widget.

Fixes: 1f95c019115c ("ASoC: mediatek: mt8195: support pcm in platform driver")
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Link: https://lore.kernel.org/r/20211230084731.31372-2-trevor.wu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/mediatek/mt8195/mt8195-dai-pcm.c
sound/soc/mediatek/mt8195/mt8195-reg.h